DM-44647: Move pipeline-dot build from cmdLineFwk to builder #292
Conversation
This commit moves the pipeline-dot build logic from cmdLineFwk into cli/script/build.py. As part of this commit, a switch to using the same back-end display args parser as --show pipeline-graph is also made.
leeskelvin
force-pushed
the
tickets/DM-44647
branch
from
492ce6c to
3608385
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #292 +/- ##
==========================================
- Coverage 87.25% 87.24% -0.02%
==========================================
Files 50 50
Lines 4576 4578 +2
Branches 787 788 +1
==========================================
+ Hits 3993 3994 +1
- Misses 421 422 +1
Partials 162 162 ☔ View full report in Codecov by Sentry. |
| @@ -582,9 +582,6 @@ def makePipeline(self, args: SimpleNamespace) -> Pipeline: | |||
| if args.save_pipeline: | |||
| pipeline.write_to_uri(args.save_pipeline) | |||
|
|
|||
| if args.pipeline_dot: | |||
| pipeline2dot(pipeline, args.pipeline_dot) | |||
There was a problem hiding this comment.
I am now thinking how this PR relates to #159 given that this is the only usage of pipeline2dot and that PR was removing it completely.
There was a problem hiding this comment.
I think this fully supersedes #159. I'm also planning to RFC dropping support for QuantumGraph GraphViz outputs, since my understanding is that those are always too big for dot to render in practice anyway, and then we can get rid of dotTools.py entirely.
leeskelvin
force-pushed
the
tickets/DM-44647
branch
3 times, most recently
from
66dac1b to
09ad34c
Compare
|
I've removed the |
leeskelvin
force-pushed
the
tickets/DM-44647
branch
from
6a8629a to
2c6993f
Compare
requirements.txt
Outdated
| lsst-pex-config @ git+https://github.com/lsst/pex_config@main | ||
| sqlalchemy | ||
| numpy >= 1.17, <2 |
There was a problem hiding this comment.
Hopefully this can be removed now.
There was a problem hiding this comment.
Thanks! Commit dropped.
leeskelvin
force-pushed
the
tickets/DM-44647
branch
from
6f27018 to
28d8a12
Compare
This commit moves the pipeline-dot build logic from cmdLineFwk into cli/script/build.py.
As part of this commit, a switch to using the same back-end display args parser as --show pipeline-graph is also made.
Checklist
doc/changes