DM-45724: Move handling of exiting exceptions to MPGraphExecutor #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #301 +/- ##
==========================================
- Coverage 89.47% 89.14% -0.33%
==========================================
Files 50 50
Lines 4360 4376 +16
Branches 723 685 -38
==========================================
Hits 3901 3901
- Misses 323 335 +12
- Partials 136 140 +4 ☔ View full report in Codecov by Sentry. |
TallJimbo
approved these changes
Aug 14, 2024
| successCount += 1 | ||
| # For some exception types we want to exit immediately with | ||
| # exception-specific exit code, but we still want to start | ||
| # debugger if |
This avoids unexpected process exits from SingleGraphExecutors level. MPGraphExecutor is a better place to handle application-level logic, potentially CmdLineFwk would be even better location, but some context is missing at that level.
andy-slac
force-pushed
the
tickets/DM-45724
branch
from
0d16400
to
0da26fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids unexpected process exits from SingleGraphExecutors level. MPGraphExecutor is a better place to handle application-level logic, potentially CmdLineFwk would be even better location, but some context is missing at that level.
Checklist
doc/changes