DM-41605: Command-line aggregator for pipetask report #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eigerx
force-pushed
the
tickets/DM-41605
branch
5 times, most recently
from
a5cce92
to
b90d10d
Compare
timj
reviewed
Aug 17, 2024
| This option will still report all `cursed` datasets and `wonky` | ||
| quanta. This is passed to `print_summary` at the end of this function. | ||
| """ | ||
| summaries: Iterable[Summary] = [] |
There was a problem hiding this comment.
Suggested change
| summaries: Iterable[Summary] = [] | |
| summaries: list[Summary] = [] |
Should fix mypy.
eigerx
force-pushed
the
tickets/DM-41605
branch
2 times, most recently
from
7a69154
to
7462c06
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #302 +/- ##
==========================================
+ Coverage 89.72% 89.73% +0.01%
==========================================
Files 50 50
Lines 4427 4522 +95
Branches 399 414 +15
==========================================
+ Hits 3972 4058 +86
- Misses 336 340 +4
- Partials 119 124 +5 ☔ View full report in Codecov by Sentry. |
eigerx
force-pushed
the
tickets/DM-41605
branch
2 times, most recently
from
aa98b41
to
e07a242
Compare
eigerx
force-pushed
the
tickets/DM-41605
branch
from
e07a242
to
afb935f
Compare
villarrealas
approved these changes
Oct 16, 2024
requirements.txt
Outdated
| @@ -6,6 +6,6 @@ networkx | |||
| lsst-resources @ git+https://github.com/lsst/resources@main | |||
| lsst-daf-butler @ git+https://github.com/lsst/daf_butler@main | |||
| lsst-utils @ git+https://github.com/lsst/utils@main | |||
| lsst-pipe-base @ git+https://github.com/lsst/pipe_base@main | |||
| lsst-pipe-base @ git+https://github.com/lsst/pipe_base@tickets/DM-41605 | |||
There was a problem hiding this comment.
Probably should remake this w/ pipe_base@main once DM-41605 is merged into main rather than pointing at the ticketed branch.
eigerx
force-pushed
the
tickets/DM-41605
branch
from
afb935f
to
46f434f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/changes