Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-45489: Add more test cover for RemoteButler queries #1042

Merged
merged 6 commits into from
Jul 31, 2024
Merged

DM-45489: Add more test cover for RemoteButler queries #1042

merged 6 commits into from
Jul 31, 2024

Commits on Jul 30, 2024

  1. Fix missing queryDataIds argument validation 

    Match the DirectButler behavior in RemoteButler  queryDataIds by throwing an ArgumentError if collections is specified without datasets.
    @dhirving
    dhirving committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    27e5d80 View commit details
    Browse the repository at this point in the history

  2. Tweak test for RemoteButler behavior 

    The query shims for RemoteButler are not able to determine whether there are any errors until they go to resolve the query, so resolve the query in a test to allow this instance of MissingDatasetTypeError to be raised lazily.
    @dhirving
    dhirving committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    5337185 View commit details
    Browse the repository at this point in the history

  3. Provide better error message for missing dimension 

    Matching the DirectButler behavior, return a more user-friendly error when an empty string is passed to order_by.
    @dhirving
    dhirving committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    2624869 View commit details
    Browse the repository at this point in the history

  4. Update query tests for new query system diagnostics 

    Update unit tests related to interpreting identifiers in queries to account for differences between the old and new query systems.
    @dhirving
    dhirving committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    56cdc0c View commit details
    Browse the repository at this point in the history

  5. Update test for minor query system differences 

    Tweak the registry query unit tests to handle minor differences between the old and new query systems.
    @dhirving
    dhirving committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    5a406b3 View commit details
    Browse the repository at this point in the history

  6. Add test cover for RemoteButler query exceptions 

    Fixed an issue where the "Hybrid" query results object for queryDataIds was testing the DirectButler implementation in some cases where it should have been testing the RemoteButler implementation.
    @dhirving
    dhirving committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    66e3efc View commit details
    Browse the repository at this point in the history