Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-45432: Add explicit tests for regions and timespans with query_datasets #1049

Merged
merged 8 commits into from
Aug 13, 2024

Conversation

timj
Copy link
Member

@timj timj commented Aug 6, 2024

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes
  • (if changing dimensions.yaml) make a copy of dimensions.yaml in configs/old_dimensions

Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.47%. Comparing base (20b5ab1) to head (c255a5c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1049      +/-   ##
==========================================
+ Coverage   89.44%   89.47%   +0.03%     
==========================================
  Files         360      360              
  Lines       45842    45879      +37     
  Branches     9406     9410       +4     
==========================================
+ Hits        41004    41052      +48     
+ Misses       3506     3496      -10     
+ Partials     1332     1331       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@timj timj requested a review from dhirving August 13, 2024 15:25
@timj timj force-pushed the tickets/DM-45432 branch 2 times, most recently from cd25270 to c255a5c Compare August 13, 2024 19:35
tests/test_simpleButler.py Outdated Show resolved Hide resolved
@timj timj force-pushed the tickets/DM-45432 branch 2 times, most recently from b579214 to c5ff8f3 Compare August 13, 2024 21:07
@timj timj merged commit f66ddda into main Aug 13, 2024
16 checks passed
@timj timj deleted the tickets/DM-45432 branch August 13, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants