Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-45767: Move CollectionType definition up a level #1055

Merged
merged 2 commits into from
Aug 14, 2024
Merged

Conversation

timj
Copy link
Member

@timj timj commented Aug 13, 2024

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes
  • (if changing dimensions.yaml) make a copy of dimensions.yaml in configs/old_dimensions

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.51%. Comparing base (b716002) to head (0885e05).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #1055    +/-   ##
========================================
  Coverage   89.51%   89.51%            
========================================
  Files         361      361            
  Lines       46137    46147    +10     
  Branches     9460     8819   -641     
========================================
+ Hits        41299    41308     +9     
  Misses       3504     3504            
- Partials     1334     1335     +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@timj timj marked this pull request as ready for review August 14, 2024 15:37
@timj timj requested a review from andy-slac August 14, 2024 15:38
Copy link
Contributor

@andy-slac andy-slac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. This probably needs a news fragment.

@timj timj merged commit 6ba7992 into main Aug 14, 2024
16 checks passed
@timj timj deleted the tickets/DM-45767 branch August 14, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants