Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-45775: Enable datastore cache for client/server butler #1057

Merged
merged 10 commits into from
Aug 21, 2024
Merged

DM-45775: Enable datastore cache for client/server butler #1057

merged 10 commits into from
Aug 21, 2024

Conversation

timj
Copy link
Member

@timj timj commented Aug 14, 2024 •
edited
Loading

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes
  • (if changing dimensions.yaml) make a copy of dimensions.yaml in configs/old_dimensions

@timj timj requested a review from dhirving August 14, 2024 19:38
@timj timj marked this pull request as ready for review August 14, 2024 19:38
@codecov Codecov
Copy link

codecov bot commented Aug 14, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 94.91525% with 6 lines in your changes missing coverage. Please review.

Project coverage is 89.56%. Comparing base (287565a) to head (262584a).
Report is 11 commits behind head on main.

Files Patch % Lines
python/lsst/daf/butler/datastore/cache_manager.py 95.55% 1 Missing and 1 partial ⚠️
.../lsst/daf/butler/datastores/fileDatastoreClient.py 33.33% 1 Missing and 1 partial ⚠️
...on/lsst/daf/butler/remote_butler/_remote_butler.py 85.71% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1057      +/-   ##
==========================================
+ Coverage   89.54%   89.56%   +0.01%     
==========================================
  Files         359      359              
  Lines       46382    46480      +98     
  Branches     9540     9567      +27     
==========================================
+ Hits        41531    41628      +97     
  Misses       3508     3508              
- Partials     1343     1344       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@timj timj force-pushed the tickets/DM-45775 branch 4 times, most recently from 547975e to 4361d1c Compare August 20, 2024 16:01
@timj
Enable datastore cache for client/server butler
a9b582c
@timj
Add ability to configure standard datastore cache to be disabled
485e622 
This allows code to use the normal cache with disabled configruation
but allow external environment variables to turn it on. This is
not possible if the code is using an explicit disabled cache
manager class.
@timj
Add new method to create by-default disabled cache manager
7b3c162 
That can be enabled via the environment.
@timj
Use internal property and internal method for cache_manager
b29f833
@timj
Allow RemoteButler to use disabled datastore cache
48d9216
@timj timj force-pushed the tickets/DM-45775 branch 4 times, most recently from 7de979a to cbcc5e9 Compare August 20, 2024 20:18
dhirving
dhirving approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@dhirving dhirving left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me

@timj timj merged commit 1b40514 into main Aug 21, 2024
18 checks passed
@timj timj deleted the tickets/DM-45775 branch August 21, 2024 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhirving dhirving dhirving approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timj @dhirving