Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-45764: Return ingest_date as astropy time from general query #1060

Merged
merged 2 commits into from
Aug 19, 2024

Conversation

andy-slac
Copy link
Contributor

There is no easy way to catch/convert ingest_date in the rows returned
from all queries. For now only the general query can return ingest_date,
so it is an easy fix for that case, though it requires checking type
of the value in that column for each row.

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes
  • (if changing dimensions.yaml) make a copy of dimensions.yaml in configs/old_dimensions

@andy-slac andy-slac changed the title DM-45764Ж Return ingest_date as astropy time from general query DM-45764: Return ingest_date as astropy time from general query Aug 16, 2024
There is no easy way to catch/convert ingest_date in the rows returned
from all queries. For now only the general query can return ingest_date,
so it is an easy fix for that case, though it requires checking type
of the value in that column for each row.
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

Attention: Patch coverage is 97.05882% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.57%. Comparing base (d09db1e) to head (6366d3b).
Report is 3 commits behind head on main.

Files Patch % Lines
...tler/direct_query_driver/_result_page_converter.py 91.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1060      +/-   ##
==========================================
+ Coverage   89.55%   89.57%   +0.02%     
==========================================
  Files         357      357              
  Lines       46173    46190      +17     
  Branches     9486     9487       +1     
==========================================
+ Hits        41349    41374      +25     
+ Misses       3488     3484       -4     
+ Partials     1336     1332       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andy-slac andy-slac merged commit 028a2be into main Aug 19, 2024
18 checks passed
@andy-slac andy-slac deleted the tickets/DM-45764 branch August 19, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants