Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-45860: Add property to DimensionGroup to make it easy to get best time/region dim for query #1066

Merged
merged 2 commits into from
Sep 6, 2024

Conversation

timj
Copy link
Member

@timj timj commented Aug 29, 2024

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes
  • (if changing dimensions.yaml) make a copy of dimensions.yaml in configs/old_dimensions

@timj timj force-pushed the tickets/DM-45860 branch 2 times, most recently from 8e970fb to 106344b Compare August 29, 2024 18:23
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.66%. Comparing base (767a556) to head (ff525f4).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1066   +/-   ##
=======================================
  Coverage   89.65%   89.66%           
=======================================
  Files         359      359           
  Lines       46671    46687   +16     
  Branches     9597     9600    +3     
=======================================
+ Hits        41844    41860   +16     
  Misses       3468     3468           
  Partials     1359     1359           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@TallJimbo TallJimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of text about very minor points, but it's all advisory: I don't have any super strong opinions because there are tradeoffs on all of these points.

python/lsst/daf/butler/dimensions/_group.py Outdated Show resolved Hide resolved
python/lsst/daf/butler/dimensions/_group.py Outdated Show resolved Hide resolved
@timj timj merged commit aa622dc into main Sep 6, 2024
18 checks passed
@timj timj deleted the tickets/DM-45860 branch September 6, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants