DM-45791: Put ingest reference time back in the correct place in test #1069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 4dbfaa9 moved the reference time calculation to after the ingest.
timj
commented
Sep 4, 2024
| dt0 = datetime.datetime.now(datetime.UTC) | ||
| self.load_data(butler, "base.yaml", "datasets.yaml") |
There was a problem hiding this comment.
I could split the load_data up into two calls but I'm not sure it makes a difference for this test.
There was a problem hiding this comment.
I think it's OK for this test to have dt0 before loading everuthing.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1069 +/- ##
=======================================
Coverage 89.54% 89.54%
=======================================
Files 359 359
Lines 46509 46509
Branches 9566 9566
=======================================
Hits 41648 41648
Misses 3511 3511
Partials 1350 1350 ☔ View full report in Codecov by Sentry. |
andy-slac
approved these changes
Sep 4, 2024
| dt0 = datetime.datetime.now(datetime.UTC) | ||
| self.load_data(butler, "base.yaml", "datasets.yaml") |
There was a problem hiding this comment.
I think it's OK for this test to have dt0 before loading everuthing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 4dbfaa9 moved the reference time calculation to after the ingest.
Checklist
doc/changesconfigs/old_dimensions