Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-46129: Make collections.query_info a single HTTP call #1074

Merged
merged 8 commits into from
Sep 11, 2024

Commits on Sep 10, 2024

  1. Make collections.query_info a single HTTP call

    Previously collections.query_info would make an HTTP call for each resolved collection.  It now does everything in a single call to the server instead.
    dhirving committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    bcf3cd2 View commit details
    Browse the repository at this point in the history
  2. Make get_info use the same endpoint as query_info

    There is no reason to add a duplicate API for this, because get_info is identical to calling query_info with a single collection name.
    dhirving committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    063d572 View commit details
    Browse the repository at this point in the history
  3. Break RegistryDefaults circular dependency

    The various Butler sub-objects (registry, collections) need to access the registry defaults.  Added a small helper class so that they don't need a reference to RemoteButler or each other in order to fetch the defaults.
    dhirving committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    694d360 View commit details
    Browse the repository at this point in the history
  4. Forward RemoteButlerRegistry to ButlerCollections

    Now that there is an independent implementation of ButlerCollections for RemoteButler, forward the equivalent Registry methods to it to reduce duplication.
    dhirving committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    a7ea9f2 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    56d6a27 View commit details
    Browse the repository at this point in the history
  6. Handle collection query optimization parameters

    Update RemoteButlerCollections to pass the new optimization parameters added in DM-45993 to the server.
    dhirving committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    8c3ca9c View commit details
    Browse the repository at this point in the history
  7. Fix summary_datasets being ignored

    When attempting to add a test for the summary_datasets parameter to ButlerCollectionInfo for RemoteButler, it turned out that it does not doing anything in the DirectButler version.
    
    This was occurring because a caching context causes this parameter to be ignored, and the cache was always enabled in query_info previously.  This cache does not have a benefit for the new implementation.
    dhirving committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    701bd48 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2024

  1. Fix minor review comments

    dhirving committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    af34091 View commit details
    Browse the repository at this point in the history