-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-34589: Add a way to mark which dimensions populate others. #685
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #685 +/- ##
=======================================
Coverage 87.81% 87.81%
=======================================
Files 274 274
Lines 36026 36049 +23
Branches 7535 7542 +7
=======================================
+ Hits 31635 31657 +22
Misses 3224 3224
- Partials 1167 1168 +1
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand why this can't have any tests? Why can't we have a small test dimensions universe that has a couple of elements in where one populates the other. We have special test dimensions.yaml content in pipe_base and ctrl_mpexec. Why can't there be one call to get_elements_populated_by in one of the dimensions tests?
I can add some tests with a custom dimensions universe later in the week. |
I think I'm changing my mind (a bit) again on how far to go on this ticket - I'm thinking now that we should update the default dimensions config to use So, since I think the rest of the migration changes are pretty close to merging over on DM-33942, let's hold this ticket up until that merges, then update the default dimensions config on this ticket after rebasing (and add a test based on that default config then). |
#674 (DM-33942) was merged. |
8ef2d3e
to
152a658
Compare
In the future, this will be used to make it easier to export dimension data without knowing the details of the dimension combinations that represent many-to-main joins (DM-34838). There's no real gain to updating the dimensions configuration before that happens, but merging these changes early is useful because it will make software versions with just this change much better able to handle future data repositories that use them in their dimensions configuration, even if the associated functionality isn't available as a result.
2e8e241
to
0bccc2b
Compare
In the future, this will be used to make it easier to export dimension data without knowing the details of the dimension combinations that represent many-to-main joins (DM-34838).
There's no real gain to updating the dimensions configuration before that happens, but merging these changes early is useful because it will make software versions with just this change much better able to handle future data repositories that use them in their dimensions configuration, even if the associated functionality isn't available as a result.
Checklist
Jenkinslocal lsstswdoc/changes