Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-38745: Add SpectractorFitParameters to storage classes #839

Merged
merged 2 commits into from
Aug 24, 2023

Conversation

mfisherlevine
Copy link
Contributor

@mfisherlevine mfisherlevine commented May 22, 2023

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (1585a23) 87.67% compared to head (a9c7625) 87.67%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #839   +/-   ##
=======================================
  Coverage   87.67%   87.67%           
=======================================
  Files         272      272           
  Lines       36107    36107           
  Branches     7552     7552           
=======================================
  Hits        31656    31656           
  Misses       3270     3270           
  Partials     1181     1181           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mfisherlevine mfisherlevine force-pushed the tickets/DM-38745 branch 3 times, most recently from 6e1f7dc to a0c6692 Compare June 6, 2023 10:37
@mfisherlevine mfisherlevine force-pushed the tickets/DM-38745 branch 4 times, most recently from e315af2 to 80accfa Compare June 15, 2023 10:12
@mfisherlevine mfisherlevine force-pushed the tickets/DM-38745 branch 2 times, most recently from 47d388d to d630543 Compare June 23, 2023 10:16
@mfisherlevine mfisherlevine force-pushed the tickets/DM-38745 branch 2 times, most recently from bbedad1 to fbdc82d Compare July 10, 2023 10:15
@timj
Copy link
Member

timj commented Jul 24, 2023

Something has gone wrong with your rebase here. There are far more commits than there should be.

@timj
Copy link
Member

timj commented Jul 24, 2023

I rebased it again and that seems to have cleaned it up.

@mfisherlevine mfisherlevine force-pushed the tickets/DM-38745 branch 2 times, most recently from 18a1930 to 3d63511 Compare August 1, 2023 16:18
@mfisherlevine mfisherlevine force-pushed the tickets/DM-38745 branch 2 times, most recently from 8eebbc9 to 7358a08 Compare August 16, 2023 11:13
@mfisherlevine mfisherlevine force-pushed the tickets/DM-38745 branch 2 times, most recently from 497ba66 to 72f89e7 Compare August 21, 2023 11:32
@mfisherlevine mfisherlevine merged commit 11710ee into main Aug 24, 2023
16 checks passed
@mfisherlevine mfisherlevine deleted the tickets/DM-38745 branch August 24, 2023 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants