DM-38084: update docs and exception messages to improve timespan-querying usability #865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TallJimbo
force-pushed
the
tickets/DM-38084
branch
from
54ba55c
to
db557ce
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #865 +/- ##
==========================================
+ Coverage 87.92% 87.94% +0.01%
==========================================
Files 273 273
Lines 35876 35896 +20
Branches 7501 7510 +9
==========================================
+ Hits 31545 31567 +22
+ Misses 3172 3170 -2
Partials 1159 1159
☔ View full report in Codecov by Sentry. |
TallJimbo
force-pushed
the
tickets/DM-38084
branch
from
7a08a34
to
187e5ad
Compare
"datetime_begin" and "datetime_end" are old and no supported in all contexts, while "timestamp" is just wrong, and dimension-qualification being optional is only sometimes true.
TallJimbo
force-pushed
the
tickets/DM-38084
branch
from
187e5ad
to
dcf44d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/changes