DM-40184: fix rare bug in QG generation with warps as an overall-input #871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't know why I previously assumed this wouldn't commute with anything; it commutes in essentially exactly the same way as a Selection (i.e. WHERE clause).
TallJimbo
force-pushed
the
tickets/DM-40184
branch
from
f1788e9
to
8879207
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #871 +/- ##
=======================================
Coverage 87.80% 87.81%
=======================================
Files 274 274
Lines 36003 36026 +23
Branches 7533 7535 +2
=======================================
+ Hits 31613 31635 +22
+ Misses 3225 3224 -1
- Partials 1165 1167 +2
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/changes