Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-40297: Stop checking dataset existence when creating deferred dataset handle #873

Merged
merged 4 commits into from
Aug 3, 2023

Conversation

timj
Copy link
Member

@timj timj commented Aug 3, 2023

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

If the datastore knows about a file that does not exist then we
have serious problems but in most cases checking that the datastore
knows about the file is enough.
@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Patch coverage: 81.81% and no project coverage change.

Comparison is base (348c15d) 87.81% compared to head (0662c7f) 87.82%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #873   +/-   ##
=======================================
  Coverage   87.81%   87.82%           
=======================================
  Files         274      274           
  Lines       36049    36052    +3     
  Branches     7542     7543    +1     
=======================================
+ Hits        31657    31662    +5     
+ Misses       3224     3223    -1     
+ Partials     1168     1167    -1     
Files Changed Coverage Δ
python/lsst/daf/butler/_butler.py 79.08% <71.42%> (+0.33%) ⬆️
python/lsst/daf/butler/datastores/fileDatastore.py 82.40% <100.00%> (-0.02%) ⬇️
tests/test_butler.py 97.83% <100.00%> (+<0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@andy-slac andy-slac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@timj timj merged commit fc214b3 into main Aug 3, 2023
15 of 16 checks passed
@timj timj deleted the tickets/DM-40297 branch August 3, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants