Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-40450: Change default value for components to False #884

Merged
merged 2 commits into from
Aug 21, 2023
Merged

Conversation

timj
Copy link
Member

@timj timj commented Aug 21, 2023

The default should be the value we want it to be during the deprecation period for the other values.

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

The default should be the value we want it to be during
the deprecation period for the other values.
@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (c732061) 87.71% compared to head (a9cd4db) 87.71%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #884   +/-   ##
=======================================
  Coverage   87.71%   87.71%           
=======================================
  Files         274      274           
  Lines       36219    36219           
  Branches     7578     7578           
=======================================
  Hits        31770    31770           
  Misses       3272     3272           
  Partials     1177     1177           
Files Changed Coverage Δ
python/lsst/daf/butler/cli/opt/options.py 93.33% <ø> (ø)
python/lsst/daf/butler/registries/remote.py 80.40% <ø> (ø)
python/lsst/daf/butler/registries/sql.py 85.04% <ø> (ø)
python/lsst/daf/butler/registry/_registry.py 96.55% <ø> (ø)
.../butler/registry/datasets/byDimensions/_manager.py 93.65% <ø> (ø)
...n/lsst/daf/butler/registry/interfaces/_datasets.py 100.00% <ø> (ø)
python/lsst/daf/butler/registry/tests/_registry.py 98.19% <ø> (ø)
tests/test_cliCmdQueryDatasetTypes.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This means that None is no longer available as an option because
the actual flag is boolean.
@timj timj merged commit 6b871c2 into main Aug 21, 2023
16 checks passed
@timj timj deleted the tickets/DM-40450 branch August 21, 2023 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants