DM-42307: Separate clustering.yaml for DC2 and RC2 cases #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
brianyanny
commented
Dec 22, 2023
brianyanny
commented
- visit_detector (step1) clustering requires distinct pipetask lists for
- DC2 (LSSTCam-imsim) and RC2 (HSC) cases
brianyanny
force-pushed
the
tickets/DM-42307
branch
from
929cca8
to
de442ec
Compare
- visit_detector (step1) clustering requires distinct pipetask lists for - DC2 (LSSTCam-imsim) and RC2 (HSC) cases - remove trailing spaces from yaml files and remove trailing empty line - remove extra files in pipelines/HSC generated by scons
brianyanny
force-pushed
the
tickets/DM-42307
branch
from
de442ec
to
052bbc6
Compare
cmsaunders
approved these changes
Dec 22, 2023
There was a problem hiding this comment.
This looks good to me, but I'm not sure that we need a special HSC clustering file if it's not changing anything. I had originally thought the visit_detector from the general clustering file should go into the HSC one, but I think that's actually going to be the configuration for most of the processing we do, and it shouldn't go into a specialized clustering file. I think you could leave out the HSC-specific file for now, but it's up to you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.