DM-46327: Exclude FGCM tasks from LSSTCam/LSSTComCam #155
Conversation
leeskelvin
force-pushed
the
tickets/DM-46327
branch
from
8913ed1
to
8388581
Compare
| @@ -75,7 +75,8 @@ tasks: | |||
| class: lsst.analysis.tools.tasks.refCatSourceAnalysis.RefCatSourceAnalysisTask | |||
| config: | |||
| # Only run metrics for analyzing the preSources: | |||
| connections.data: preSourceTable_visit_gaia_dr3_20230707_match_astrom | |||
| connections.data: preSourceTable_visit_uw_stars_20240524_match_astrom | |||
There was a problem hiding this comment.
I think what was already here was correct. The uw_stars... catalog is only for ComCamSim. (The outputName below looks correct however.)
There was a problem hiding this comment.
I think this was inadvertently changed in an effort to diagnose the cascade of errors, comparing against LSSTComCamSim. Changed back, here and for LSSTComCam.
| @@ -75,7 +75,8 @@ tasks: | |||
| class: lsst.analysis.tools.tasks.refCatSourceAnalysis.RefCatSourceAnalysisTask | |||
| config: | |||
| # Only run metrics for analyzing the preSources: | |||
| connections.data: preSourceTable_visit_gaia_dr3_20230707_match_astrom | |||
| connections.data: preSourceTable_visit_uw_stars_20240524_match_astrom | |||
There was a problem hiding this comment.
Same as LSSTCam comment, what was here before should be correct.
There was a problem hiding this comment.
Changed back to preSourceTable_visit_gaia_dr3_20230707_match_astrom.
| photometricMatchVisit: | ||
| class: lsst.analysis.tools.tasks.photometricCatalogMatch.PhotometricCatalogMatchVisitTask | ||
| config: | ||
| extraColumns: ["x", "y", "ap09Flux", "ap09FluxErr"] |
There was a problem hiding this comment.
Do these have to go here because they're not present when photometricMatchPreVisit is run and so would cause that task to fail if they were in obs_subaru?
There was a problem hiding this comment.
If you're referring to the extraColumns, I have no opinion on those. They were simply copied in verbatim from $ANALYSIS_TOOLS_DIR/pipelines/visitQualityCore.yaml, a YAML which gets imported into this YAML. That makes photometricMatchVisit visible in this YAML. I needed to over-ride the referenceCatalogLoader.doApplyColorTerms config to false, which necessitates me redefining the entire task and prior configs again here.
There was a problem hiding this comment.
I thought this was the case, but in a recent slack thread there was a big discussion about how the configs are actually supposed to be inherited.
| class: lsst.analysis.tools.tasks.photometricCatalogMatch.PhotometricCatalogMatchVisitTask | ||
| config: | ||
| extraColumns: ["x", "y", "ap09Flux", "ap09FluxErr"] | ||
| referenceCatalogLoader.doApplyColorTerms: false |
There was a problem hiding this comment.
Can you make this change in obs_lsst like you do for photometricCatalogMatchTask?
There was a problem hiding this comment.
Yes, that's much neater, thank you.
| @@ -116,6 +122,7 @@ tasks: | |||
| connections.catalog: preSourceTable_visit | |||
| connections.targetCatalog: preSourceTable_visit | |||
| connections.matchedCatalog: preSourceTable_visit_gaia_dr3_20230707_photoMatch | |||
| referenceCatalogLoader.doApplyColorTerms: false | |||
There was a problem hiding this comment.
Same as above, can't you set this in obs_lsst?
| class: lsst.analysis.tools.tasks.photometricCatalogMatch.PhotometricCatalogMatchVisitTask | ||
| config: | ||
| extraColumns: ["x", "y", "ap09Flux", "ap09FluxErr"] | ||
| referenceCatalogLoader.doApplyColorTerms: false |
There was a problem hiding this comment.
Same as above, can you set this in obs_lsst?
leeskelvin
force-pushed
the
tickets/DM-46327
branch
from
8388581
to
71d5c72
Compare
|
Thanks @cmsaunders, configs have been moved to |
No description provided.