DM-39683: Break faro task up into visit, matched, and tract-based subsets #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eigerx
changed the title
TallJimbo
approved these changes
Jun 16, 2023
pipelines/_ingredients/HSC/DRP.yaml
Outdated
| description: | | ||
| Set of tasks for calculation of metrics via faro. | ||
| These tasks are a mix of visit- and tract-level and must be run globally | ||
| for RC2. |
There was a problem hiding this comment.
This last description section should now be removed.
TallJimbo
reviewed
Jun 21, 2023
| which are available after consolidateSourceTable (step2). | ||
| Tasks that require coadd products use Object Tables which are available | ||
| after consolidateObjectTable (step3). | ||
| subsets: |
There was a problem hiding this comment.
You've added an extra subsets: header here (there's also one way earlier, since this file also defines all the stepN subsets). You'll want to delete this one and then de-dent everything below it.
There was a problem hiding this comment.
Should I keep the one way earlier or is that supposed to be there?
There was a problem hiding this comment.
The one way earlier should stay as-is; just drop this one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.