DM-38498: Document that certain faro steps now need a band constraint. #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a task has band in its quantum dimensions but does not have band in the dimensions of any of its inputs, it will run over all bands known to any instrument unless those bands are constrained by the data query. It was an accident of the old QG generation algorithm that this wasn't happening before (unrelated tasks in the same step were providing a band constraint, but the middleware now sees them as unrelated).
TallJimbo
force-pushed
the
tickets/DM-38498
branch
from
ee08fd7
to
5810ee8
Compare
andy-slac
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a task has band in its quantum dimensions but does not have band in the dimensions of any of its inputs, it will run over all bands known to any instrument unless those bands are constrained by the data query. It was an accident of the old QG generation algorithm that this wasn't happening before (unrelated tasks in the same step were providing a band constraint, but the middleware now sees them as unrelated).