Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-48427: Add column groups #127

Merged
merged 7 commits into from
Jan 28, 2025
Merged

DM-48427: Add column groups #127

merged 7 commits into from
Jan 28, 2025

Conversation

JeremyMcCormick
Copy link
Collaborator

@JeremyMcCormick JeremyMcCormick commented Jan 15, 2025

Checklist

  • Ran Jenkins
  • Added a release note for user-visible changes to docs/changes

@JeremyMcCormick JeremyMcCormick marked this pull request as draft January 15, 2025 19:16
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 98.71795% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.09%. Comparing base (8294325) to head (da3a7f2).
Report is 8 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
python/felis/datamodel.py 98.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #127      +/-   ##
==========================================
+ Coverage   92.91%   93.09%   +0.17%     
==========================================
  Files          23       23              
  Lines        2895     2967      +72     
  Branches      292      299       +7     
==========================================
+ Hits         2690     2762      +72     
  Misses        118      118              
  Partials       87       87              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JeremyMcCormick JeremyMcCormick requested a review from gpdf January 24, 2025 23:19
@JeremyMcCormick JeremyMcCormick marked this pull request as ready for review January 27, 2025 18:20
@JeremyMcCormick JeremyMcCormick force-pushed the tickets/DM-48427 branch 5 times, most recently from 88b567c to 080bd09 Compare January 28, 2025 00:08
Copy link

@gpdf gpdf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved (there is a small typo that could be fixed, not required). Looking forward to the next steps.

Makefile Outdated Show resolved Hide resolved
@JeremyMcCormick JeremyMcCormick merged commit 9962b0d into main Jan 28, 2025
16 checks passed
@JeremyMcCormick JeremyMcCormick deleted the tickets/DM-48427 branch January 28, 2025 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants