Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-48616: Remove old TAP_SCHEMA module #131

Merged
merged 2 commits into from
Jan 29, 2025
Merged

Conversation

JeremyMcCormick
Copy link
Collaborator

@JeremyMcCormick JeremyMcCormick commented Jan 27, 2025

Checklist

  • Ran Jenkins
  • Added a release note for user-visible changes to docs/changes

Copy link

codecov bot commented Jan 27, 2025

Codecov Report

Attention: Patch coverage is 92.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 92.35%. Comparing base (9962b0d) to head (64356d3).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
python/felis/cli.py 84.61% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #131      +/-   ##
==========================================
- Coverage   93.09%   92.35%   -0.74%     
==========================================
  Files          23       21       -2     
  Lines        2967     2615     -352     
  Branches      299      257      -42     
==========================================
- Hits         2762     2415     -347     
- Misses        118      127       +9     
+ Partials       87       73      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JeremyMcCormick JeremyMcCormick force-pushed the tickets/DM-48616 branch 2 times, most recently from 57f6c83 to 87cba9e Compare January 27, 2025 23:06
@JeremyMcCormick JeremyMcCormick requested a review from gpdf January 27, 2025 23:11
@JeremyMcCormick JeremyMcCormick force-pushed the tickets/DM-48616 branch 2 times, most recently from 447eb18 to dcc95e7 Compare January 28, 2025 00:43
Copy link
Contributor

@stvoutsin stvoutsin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me. I haven't reviewed the tap_schema module extensively but as far as the changes to the cli here I can't see any issues.

python/felis/cli.py Show resolved Hide resolved
@JeremyMcCormick JeremyMcCormick merged commit c5a10cf into main Jan 29, 2025
14 of 16 checks passed
@JeremyMcCormick JeremyMcCormick deleted the tickets/DM-48616 branch January 29, 2025 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants