-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-44878: Fill in the TAP_SCHEMA size attribute #83
Conversation
0568f0d
to
cf20718
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #83 +/- ##
==========================================
- Coverage 91.47% 90.71% -0.77%
==========================================
Files 14 14
Lines 1643 1659 +16
Branches 347 352 +5
==========================================
+ Hits 1503 1505 +2
- Misses 84 97 +13
- Partials 56 57 +1 ☔ View full report in Codecov by Sentry. |
2302147
to
2ba31af
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One requested change before merging, see regular expression rewording
2ba31af
to
d2ae1d0
Compare
d2ae1d0
to
41e065e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Future work on testing is indicated, though.
41e065e
to
4b3f231
Compare
This needs to be fixed up due to changes from #89. |
4b3f231
to
e455ef8
Compare
This should be fixed now. |
The type hint should be `Schema` and not a `MutableMapping`.
The existing type hints were too restrictive based on the valid values for arraysize from the IVOA VOTable standard.
Use the value for arraysize to set the size attribute in the TAP data.
e455ef8
to
e01a0a2
Compare
size
attribute based on the value ofvotable_arraysize
from the columnNone
which will result in a null being inserted. This includes the case where arraysize is*
or a blank string.votable_arraysize
field on the Pydantic model to accept a string or an integertest_tap