DM-44507: Investigate unexpectedly large transform passed to WarpedPsf in diffim #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enourbakhsh
commented
May 24, 2024
| @@ -390,7 +390,7 @@ def run(self, template, science, sources, finalizedPsfApCorrCatalog=None, | |||
| try: | |||
There was a problem hiding this comment.
Should we add a few words just above this try...except block explaining why we added lsst.pex.exceptions.RangeError here?
There was a problem hiding this comment.
Sure, more explanation is helpful. If you are adding that comment, also mention that we catch InvalidParameterError in case the point where we are evaluating the PSF lands in a gap in the template.
enourbakhsh
force-pushed
the
tickets/DM-44507
branch
2 times, most recently
from
3729e0c to
4c62949
Compare
enourbakhsh
force-pushed
the
tickets/DM-44507
branch
from
4c62949 to
9ca000c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.