DM-43849: Create spatiallySampledMetric to visualize the diffim kernel #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isullivan
approved these changes
Jun 19, 2024
python/lsst/ip/diffim/utils.py
Outdated
Comment on lines
859
to
861
| This is following Robert's code at | ||
| https://lsstc.slack.com/archives/C2JPMCF5X/p1715784207956889 | ||
| https://lsstc.slack.com/archives/C2JPMCF5X/p1715865918632319 |
There was a problem hiding this comment.
I don't think we should have references to Slack conversations in code.
python/lsst/ip/diffim/utils.py
Outdated
| @@ -853,6 +853,64 @@ def detectDipoleSources(self, doMerge=True, diffim=None, detectSigma=5.5, grow=3 | |||
| return detectTask, schema | |||
|
|
|||
|
|
|||
| def getKernelCenterDisplacement(kernel, x, y, im=None): | |||
There was a problem hiding this comment.
Make sure to also add this function to __all__
python/lsst/ip/diffim/utils.py
Outdated
|
|
||
| # obtain the kernel image | ||
| hsize = kernel.getWidth()//2 | ||
| krnl_sum = kernel.computeImage(im, doNormalize=False, x=x, y=y) |
There was a problem hiding this comment.
Here and elsewhere spell out kernel_sum
python/lsst/ip/diffim/utils.py
Outdated
| The x position on the detector to evaluate the kernel | ||
| y : `float` | ||
| The y position on the detector to evaluate the kernel | ||
| im : `~lsst.afw.image._image.ImageD` |
There was a problem hiding this comment.
Here and elsewhere spell out image
There was a problem hiding this comment.
Also, omit the _image in the type definition, it should just be ~lsst.afw.image.Image
| center of the extraction of the kernel | ||
| dy : `float` | ||
| The displacement of the kernel averaged peak, with respect to the | ||
| center of the extraction of the kernel |
There was a problem hiding this comment.
add pos_angle and length to the return definition
BrunoSanchez
force-pushed
the
tickets/DM-43849
branch
from
e2d6358 to
17542f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.