DM-47010: Drop obsoleted TODO comment. #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Coming from the |
GetTemplateTask in DRP now reads 'pvi', which already has the final calibrations.
TallJimbo
force-pushed
the
tickets/DM-47010
branch
from
440f92e to
d17a2b1
Compare
|
You may be right, but I'm grappling with higher-level questions about conventions for defining similarly-named connections on DM-47320 right now, and I'd prefer to wait until those are resolved before adding any new config options (since those take an RFC and deprecation period to get rid of). |
arunkannawadi
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetTemplateTask in DRP now reads 'pvi', which already has the final calibrations.