DM-15180: Turn off coordinate covariance calculation #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmsaunders
force-pushed
the
tickets/DM-15180
branch
from
0f54b15
to
bd42563
Compare
isullivan
approved these changes
Sep 8, 2023
| @@ -172,7 +172,7 @@ def calculateThreshold(self, exposure, seed, sigma=None, minFractionSourcesFacto | |||
| peaks = source.getFootprint().getPeaks() | |||
| assert len(peaks) == 1 | |||
| source.set(key, peaks[0].getF()) | |||
| source.updateCoord(exposure.getWcs()) | |||
| source.updateCoord(exposure.getWcs(), include_covariance=False) | |||
There was a problem hiding this comment.
Could you add a comment explaining why covariance is turned off here?
There was a problem hiding this comment.
Done; for further context, my read of the code was that the source catalog would not be used outside this function, so there was no point adding the needed columns to the catalog and doing extra calculations.
cmsaunders
force-pushed
the
tickets/DM-15180
branch
from
bd42563
to
6fbeb68
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.