DM-42663: Change RequireUnresolved to use moments-based classifier by default. #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erykoff
force-pushed
the
tickets/DM-42663
branch
from
cd5a933
to
dd086e1
Compare
TallJimbo
approved these changes
Feb 22, 2024
| doc="Name of column for star/galaxy separation") | ||
|
|
||
| def setDefaults(self): | ||
| """Set default | ||
|
|
||
| ``base_ClassificationExtendedness_value < 0.5`` means unresolved. | ||
| ``base_ClassificationSizeExtendedness_value < 0.1`` means unresolved. |
There was a problem hiding this comment.
I think we should remove this comment. The value is configurable and not intrinsically meaningful. It didn't matter when extendedness was behaving like a boolean. Perhaps, change it to ,,, _value < maximum is unresolved, or just lower values correspond to unresolved sources.
arunkannawadi
approved these changes
Feb 22, 2024
erykoff
force-pushed
the
tickets/DM-42663
branch
from
dd086e1
to
f8b0ce0
Compare
erykoff
force-pushed
the
tickets/DM-42663
branch
from
84c8f80
to
18a8f07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.