DM-47385: Refine mask exclusion behavior in removeBadPixels (aka cancel original masks) #398
+6
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isullivan
approved these changes
Nov 8, 2024
| """ | ||
| badPixelMask = mask.getPlaneBitMask(self.config.excludeMaskPlanes) | ||
| badPixels = mask.subset(middle.getBBox()).array & badPixelMask > 0 | ||
| badPixelMask = lsst.afw.image.Mask.getPlaneBitMask(self.config.excludeMaskPlanes) |
There was a problem hiding this comment.
Don't set this back to what it was, since the global definition is not necessarily correct. Use middle.mask.getPlaneBitMask(..
In principle, convolution-induced mask growth may block some good sources near zeroed-out regions, so we switched to the original masked regions. Unfortunately in practice, bogus diaSources appeared near masked regions, so we are undoing this change and living with losing some edge-y diaSources.
mrawls
force-pushed
the
tickets/DM-47385
branch
from
3361282
to
4bc87d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In principle, convolution-induced mask growth may block some good sources near zeroed-out regions, so we switched to the original masked regions. Unfortunately in practice, bogus diaSources appeared near masked regions, so we are undoing this change and living with losing some edge-y diaSources.