DM-43101: Adjust visit definition tests to properly handle universe #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than trying to guess the universe read it from the butler itself. Also name the v2 exposure JSON file properly and declare that it should be ued for universes 2, 3, 4 and 5.
|
@TallJimbo turns out I missed that obs_base was failing a test. I cleaned up the exposure reading so it is now explicit about the universe version that is being used. In theory I can remove the older versions but sometimes it's nice to allow a test to pass during a transition period in case there is an obs_base / daf_butler mismatch. |
TallJimbo
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than trying to guess the universe read it from the butler itself. Also name the v2 exposure JSON file properly and declare that it should be used for universes 2, 3, 4 and 5.
Checklist
doc/changes