DM-45209: Fix E721 error and general pyupgrade fixes #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #111 +/- ##
==========================================
+ Coverage 85.74% 85.87% +0.13%
==========================================
Files 46 46
Lines 3613 3604 -9
==========================================
- Hits 3098 3095 -3
+ Misses 515 509 -6 ☔ View full report in Codecov by Sentry. |
timj
commented
Jul 11, 2024
timj
commented
Jul 11, 2024
| @@ -1384,9 +1365,12 @@ def saveToStream(self, outfile, root="config", skipImports=False): | |||
| configType = type(self) | |||
| typeString = _typeStr(configType) | |||
| outfile.write(f"import {configType.__module__}\n") | |||
| # We are required to write this on a single line because | |||
There was a problem hiding this comment.
As a general comment, I have seen people reformat config .py files to make them look neater and I now worry that those will no longer be readable.
ktlim
approved these changes
Jul 11, 2024
This required a change to the regex that parses the class name on read. Also changed the code to use f-string.
ForwardRef needs to explicitly call out recursive_guard in python 3.12.
Should not rely on optional daf_base.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/changes