DM-30891: Pipeline improvements to support drp_pipe creation #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timj
reviewed
Nov 30, 2021
python/lsst/pipe/base/pipelineIR.py
Outdated
| RuntimeError | ||
| Raised if ``path`` is relative but ``directory`` is `None`. | ||
| """ | ||
| uri = ButlerURI(os.path.expandvars(path), forceAbsolute=False) |
There was a problem hiding this comment.
expandvars does now happen inside ButleRURI for schemeless URIs so this is no longer needed (when the butler Config code was written that wasn't true).
TallJimbo
force-pushed
the
tickets/DM-30891
branch
2 times, most recently
from
45e7e24
to
d18110f
Compare
TallJimbo
force-pushed
the
tickets/DM-30891
branch
3 times, most recently
from
9236f41
to
2d13499
Compare
TallJimbo
force-pushed
the
tickets/DM-30891
branch
from
2d13499
to
205747a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is building towards support for writing a pipeline in "expanded form": a directory (or maybe a tarball) containing a single YAML file and completely-resolved configuration files for all tasks.
So far it's just support for putting relative paths in pipelines and various small cleanups.
Checklist
doc/changes