DM-33204: Use ResourcePath instead of ButlerURI throughout. #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timj
commented
Jan 11, 2022
| Location of document to write a `PipelineIR` object. | ||
| """ | ||
| butlerUri = ButlerURI(uri) | ||
| butlerUri.write(yaml.dump(self.to_primitives(), sort_keys=False).encode()) | ||
| with ResourcePath(uri).open("w") as buffer: |
There was a problem hiding this comment.
@TallJimbo I was torn whether to keep the I/O code as it was or adopt the new form that you had written on the branch (also the from_uri method above).
timj
changed the title
timj
force-pushed
the
tickets/DM-33204
branch
from
0d8c3c1
to
6964a3e
Compare
timj
commented
Jan 11, 2022
| @@ -234,7 +236,8 @@ def applyTo(self, config): | |||
|
|
|||
| for otype, override in self._overrides: | |||
| if otype is OverrideTypes.File: | |||
| config.load(override) | |||
| with override.open("r") as buffer: | |||
There was a problem hiding this comment.
Now that ResourcePath is a standalone package we should consider using it in pex_config directly.
Also replaces a few Union[str, ButlerURI] and similar with the new ResourcePathExpression type alias.
timj
force-pushed
the
tickets/DM-33204
branch
from
6964a3e
to
0588191
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also replaces a few Union[str, ButlerURI] and similar with the new
ResourcePathExpression type alias.
This is essentially a cherry pick of commit b014171 from #222.
Checklist
doc/changes