Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-39760: Make NoDimensionsTask test utility consistent about storage classes. #346

Merged
merged 1 commit into from
Jun 23, 2023

Commits on Jun 23, 2023

  1. Make NoDimensionsTask test utility consistent about storage classes.

    The config option provided by this task to change its output storage
    class actually only change the Python type returned, making that type
    inconsistent with the storage class it declared in its connections.
    This means we've long been testing essentially the wrong behavior.
    
    This also switches the default for outputSC from 'dict' to
    'StructuredDataDict', since it's supposed to be a storage class name,
    not a pytype.  This wasn't causing trouble, but it was very confusing.
    TallJimbo committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    cf2b212 View commit details
    Browse the repository at this point in the history