Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-39915: Change use of butler.datastore now that it's deprecated #354

Merged
merged 7 commits into from
Jul 11, 2023

Conversation

timj
Copy link
Member

@timj timj commented Jul 6, 2023

Relies on lsst/daf_butler#862

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03 🎉

Comparison is base (b63a137) 82.72% compared to head (8704071) 82.76%.

❗ Current head 8704071 differs from pull request most recent head e705081. Consider uploading reports for the commit e705081 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #354      +/-   ##
==========================================
+ Coverage   82.72%   82.76%   +0.03%     
==========================================
  Files          66       66              
  Lines        7269     7268       -1     
  Branches     1418     1418              
==========================================
+ Hits         6013     6015       +2     
+ Misses       1007     1006       -1     
+ Partials      249      247       -2     
Impacted Files Coverage Δ
python/lsst/pipe/base/executionButlerBuilder.py 66.21% <100.00%> (ø)
...thon/lsst/pipe/base/graph/_versionDeserializers.py 67.20% <100.00%> (-0.14%) ⬇️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@timj timj force-pushed the tickets/DM-39915 branch 3 times, most recently from c3d4a12 to 9ca6691 Compare July 10, 2023 17:29
Copy link
Contributor

@andy-slac andy-slac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, few minor comments.

doc/lsst.pipe.base/creating-a-pipelinetask.rst Outdated Show resolved Hide resolved
doc/lsst.pipe.base/creating-a-pipelinetask.rst Outdated Show resolved Hide resolved
doc/lsst.pipe.base/creating-a-pipelinetask.rst Outdated Show resolved Hide resolved
doc/lsst.pipe.base/creating-a-pipelinetask.rst Outdated Show resolved Hide resolved
@timj timj force-pushed the tickets/DM-39915 branch 7 times, most recently from b46df0a to 0dcb051 Compare July 10, 2023 20:26
@@ -0,0 +1,41 @@
name: "Check commits can be merged"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andy-slac I think I have something working now. Can you take a quick look at this action and review it please?

@timj timj force-pushed the tickets/DM-39915 branch 2 times, most recently from 1a98be9 to 8704071 Compare July 10, 2023 20:49
@timj timj merged commit 1344297 into main Jul 11, 2023
@timj timj deleted the tickets/DM-39915 branch July 11, 2023 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants