Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-40254: Improve handling of calibration datasets in graph builder #362

Merged
merged 2 commits into from
Aug 1, 2023

Conversation

andy-slac
Copy link
Contributor

There may be multiple calibration datasets for the same dataset type and
data ID in one graph (with different timespans). This patch changes internal
graph builder structure for prerequisite datasets to allow multiple datasets
for one data ID.

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Patch coverage: 60.46% and project coverage change: -0.09% ⚠️

Comparison is base (7e71b86) 82.67% compared to head (caa5298) 82.59%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #362      +/-   ##
==========================================
- Coverage   82.67%   82.59%   -0.09%     
==========================================
  Files          66       66              
  Lines        7321     7349      +28     
  Branches     1432     1443      +11     
==========================================
+ Hits         6053     6070      +17     
- Misses       1019     1031      +12     
+ Partials      249      248       -1     
Files Changed Coverage Δ
python/lsst/pipe/base/graphBuilder.py 61.20% <60.46%> (-0.38%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

There may be multiple calibration datasets for the same dataset type and
data ID in one graph (with different timespans). This patch changes internal
graph builder structure for prerequisite datasets to allow multiple datasets
for one data ID.
@andy-slac andy-slac merged commit 496a576 into main Aug 1, 2023
12 of 14 checks passed
@andy-slac andy-slac deleted the tickets/DM-40254 branch August 1, 2023 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants