DM-45536: address edge cases in task mocking system #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'd prefer we not use this approach to signalling deferred loads to QuantumContext at all, but removing it is way out of scope.
TallJimbo
force-pushed
the
tickets/DM-45536
branch
from
a2f26f1
to
36fc00e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #432 +/- ##
==========================================
- Coverage 80.24% 80.20% -0.04%
==========================================
Files 96 96
Lines 10977 10975 -2
Branches 2100 2099 -1
==========================================
- Hits 8808 8803 -5
- Misses 1822 1824 +2
- Partials 347 348 +1 ☔ View full report in Codecov by Sentry. |
timj
approved these changes
Aug 2, 2024
| """The data ID for this dataset.""" | ||
| return self.datasetRef.dataId | ||
| def __getattr__(self, name: str) -> Any: | ||
| return getattr(self.datasetRef, name) |
There was a problem hiding this comment.
This change is because you needed some other method on datasetRef? Or because you wanted to simplify the code a bit?
There was a problem hiding this comment.
Yes, there was some previously-unused code in the mocking stuff that needed id that was uncovered by the other change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/changes