Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-40443: Remove interfaces deprecated on DM-40441. #434

Merged
merged 2 commits into from
Aug 11, 2024
Merged

Conversation

timj
Copy link
Member

@timj timj commented Aug 8, 2024

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

Copy link

codecov bot commented Aug 8, 2024

Codecov Report

Attention: Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.

Project coverage is 81.23%. Comparing base (1b56416) to head (76fc56e).

Files Patch % Lines
python/lsst/pipe/base/tests/simpleQGraph.py 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #434      +/-   ##
==========================================
+ Coverage   79.99%   81.23%   +1.24%     
==========================================
  Files          98       96       -2     
  Lines       11201    10922     -279     
  Branches     2145     2085      -60     
==========================================
- Hits         8960     8873      -87     
+ Misses       1882     1691     -191     
+ Partials      359      358       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member Author

@timj timj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can not approve (I opened the PR) but looks good to me.

@@ -0,0 +1,9 @@
Removed deprecated code scheduled to be removed after v27:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TallJimbo can you look at the news fragment please?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@timj timj merged commit 9eaaaf2 into main Aug 11, 2024
13 checks passed
@timj timj deleted the tickets/DM-40443 branch August 11, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants