DM-46298: Stop using private Butler clone method #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Butler now has a public method equivalent to the private method that was being used in unit tests previously.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #445 +/- ##
==========================================
- Coverage 83.52% 83.51% -0.02%
==========================================
Files 97 97
Lines 11426 11426
Branches 2192 2192
==========================================
- Hits 9544 9542 -2
- Misses 1528 1529 +1
- Partials 354 355 +1 ☔ View full report in Codecov by Sentry. |
TallJimbo
approved these changes
Sep 16, 2024
dhirving
force-pushed
the
tickets/DM-46298
branch
from
f08e741
to
a733e32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Butler now has a public method equivalent to the private
_clonemethod that was being used in unit tests previously.Checklist
doc/changes