DM-46351: Add debug log in _pipeline_graph to ID task label #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leeskelvin
force-pushed
the
tickets/DM-46351
branch
2 times, most recently
from
94f502d
to
2fbfd18
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #447 +/- ##
=======================================
Coverage 83.51% 83.51%
=======================================
Files 97 97
Lines 11426 11427 +1
Branches 2192 2192
=======================================
+ Hits 9542 9543 +1
Misses 1529 1529
Partials 355 355 ☔ View full report in Codecov by Sentry. |
natelust
approved these changes
Sep 16, 2024
| @@ -712,6 +712,7 @@ def add_task( | |||
| label = task_class._DefaultName | |||
| if config is None: | |||
| config = task_class.ConfigClass() | |||
| _LOG.debug("Task: %s %s", label, task_class) | |||
There was a problem hiding this comment.
I think something more verbose would be more helpful when disambiguating debug logs. Maybe something like Adding task with label: %s and class: %s to the pipeline graph
There was a problem hiding this comment.
The current ticket produces output that looks like this:
lsst.pipe.base.pipeline_graph DEBUG: Task: photometricMatchVisit <class 'lsst.analysis.tools.tasks.photometricCatalogMatch.PhotometricCatalogMatchVisitTask'>
Your suggestion would produce output that looks like this:
lsst.pipe.base.pipeline_graph DEBUG: Adding task with label: photometricMatchVisit and class: <class 'lsst.analysis.tools.tasks.photometricCatalogMatch.PhotometricCatalogMatchVisitTask'> to the pipeline graph
Is the double "class" what you had in mind?
There was a problem hiding this comment.
Having discussed in-person, modifying to:
Adding task %s %s to the pipeline graph
2fbfd18
to
a6b2fbe
Compare
leeskelvin
force-pushed
the
tickets/DM-46351
branch
from
a6b2fbe
to
3eead01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/changes