DM-46776: Add butler zip-from-graph command #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #452 +/- ##
==========================================
- Coverage 83.21% 83.00% -0.21%
==========================================
Files 101 102 +1
Lines 12085 12135 +50
Branches 1524 1535 +11
==========================================
+ Hits 10056 10073 +17
- Misses 1622 1655 +33
Partials 407 407 ☔ View full report in Codecov by Sentry. |
timj
force-pushed
the
tickets/DM-46776
branch
2 times, most recently
from
c2102e1
to
919a181
Compare
3 tasks
andy-slac
approved these changes
Oct 25, 2024
Comment on lines
+71
to
+77
| original_output_refs: set[DatasetRef] = set(qgraph.globalInitOutputRefs()) | ||
| for task_def in qgraph.iterTaskGraph(): | ||
| if refs := qgraph.initOutputRefs(task_def): | ||
| original_output_refs.update(refs) | ||
| for qnode in qgraph: | ||
| for otherRefs in qnode.quantum.outputs.values(): | ||
| original_output_refs.update(otherRefs) |
There was a problem hiding this comment.
Would it be useful to have that code as a method in the graph class?
timj
force-pushed
the
tickets/DM-46776
branch
2 times, most recently
from
bc4053c
to
49a5cd8
Compare
timj
force-pushed
the
tickets/DM-46776
branch
3 times, most recently
from
1d525e6
to
aa86329
Compare
Not installing anything that uses conda forge.
timj
force-pushed
the
tickets/DM-46776
branch
from
aa86329
to
917cffa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on lsst/daf_butler#1105
Checklist
doc/changes