Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-35396: Record provenance in QuantumContext #464

Merged
merged 15 commits into from
Feb 4, 2025
Merged

DM-35396: Record provenance in QuantumContext #464

merged 15 commits into from
Feb 4, 2025

Conversation

timj
Copy link
Member

@timj timj commented Jan 24, 2025

Requires lsst/daf_butler#1147

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@timj timj force-pushed the tickets/DM-35396 branch from 793d618 to 3af06d4 Compare January 24, 2025 20:25
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 88.88889% with 3 lines in your changes missing coverage. Please review.

Project coverage is 82.30%. Comparing base (fcfd244) to head (dd217c8).
Report is 16 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
python/lsst/pipe/base/_quantumContext.py 84.61% 2 Missing ⚠️
python/lsst/pipe/base/caching_limited_butler.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #464      +/-   ##
==========================================
- Coverage   82.31%   82.30%   -0.02%     
==========================================
  Files         107      107              
  Lines       12687    12702      +15     
  Branches     1626     1628       +2     
==========================================
+ Hits        10443    10454      +11     
- Misses       1811     1814       +3     
- Partials      433      434       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@timj timj force-pushed the tickets/DM-35396 branch from 3af06d4 to 29d5ae2 Compare January 24, 2025 20:29
Copy link
Member

@TallJimbo TallJimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a CachingLimitedButler in this package that needs to get the new put signature.

Copy link
Contributor

@andy-slac andy-slac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

python/lsst/pipe/base/mermaid_tools.py Outdated Show resolved Hide resolved
@timj timj force-pushed the tickets/DM-35396 branch 2 times, most recently from 556b3ef to 86a910c Compare February 4, 2025 19:38
@timj timj force-pushed the tickets/DM-35396 branch from 86a910c to ea44f8a Compare February 4, 2025 19:50
@timj timj force-pushed the tickets/DM-35396 branch from ea44f8a to dd217c8 Compare February 4, 2025 20:51
@timj timj merged commit 704effe into main Feb 4, 2025
14 checks passed
@timj timj deleted the tickets/DM-35396 branch February 4, 2025 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants