DM-45990: Create initial_pvi background metric #1114
+15
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enourbakhsh
force-pushed
the
tickets/DM-45990
branch
4 times, most recently
from
38bd2ad to
7c0f29f
Compare
enourbakhsh
force-pushed
the
tickets/DM-45990
branch
5 times, most recently
from
204d9c0 to
941cc32
Compare
mrawls
approved these changes
May 7, 2025
There was a problem hiding this comment.
Please rebase into a single commit. I suggest you add a line to the update_background_stats docstring that makes it clear this method adds two entries to summary: skyBg and skyBgNormRange, and (bonus level) a one-sentence description of what each one is. Otherwise it feels like stealth undocumented things that would warrant a "Returns" docstring if it weren't just updating summary in place.
enourbakhsh
force-pushed
the
tickets/DM-45990
branch
from
941cc32 to
2e72753
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.