DM-50755: Refactor SkyCorrectionTask to optimize memory usage #1125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leeskelvin
force-pushed
the
tickets/DM-50755
branch
5 times, most recently
from
1015169 to
29d47c6
Compare
| else: | ||
| # Here we clone the imaging data to avoid modifying data which is | ||
| # used in downstream processing. | ||
| calExp: ExposureF = calExpHandle.clone() |
There was a problem hiding this comment.
I don't see from __future__ import annotations. Does this type hint work without that?
There was a problem hiding this comment.
Thank you! Added.
leeskelvin
force-pushed
the
tickets/DM-50755
branch
2 times, most recently
from
42c5dfd to
a2dab1b
Compare
leeskelvin
force-pushed
the
tickets/DM-50755
branch
from
379898b to
b4dd916
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.