DM-46582: Compute TEX metric. #1159
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PFLeget
force-pushed
the
tickets/DM-46582
branch
from
5ca5aae to
533526f
Compare
|
|
||
| else: | ||
|
|
||
| self.isTEXComputationDone = True |
There was a problem hiding this comment.
Should this be done so early in the block? What if this block exited early because there weren't enough sources?
There was a problem hiding this comment.
I don't see where it can happen. Right now, if this is True, it will do the upper block and if not it will set this to True and set everything to nan and then compute. If the compute don't work it will be nan.
PFLeget
force-pushed
the
tickets/DM-46582
branch
from
533526f to
7edf784
Compare
PFLeget
force-pushed
the
tickets/DM-46582
branch
from
c3bf15d to
fb31b2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.