DM-52922: Incremental Object table column cleanup #1165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schemas/Object.yaml
Outdated
| - ['ext_convolved_', ''] | ||
| - ['ext_gaap_GaapFlux_1_15x_0_7', 'gaap0p7Flux'] | ||
| - ['ext_gaap_GaapFlux_1_15x_1_0', 'gaap1p0Flux'] | ||
| - ['ext_gaap_GaapFlux_1_15x_1_5', 'gaap1p5Flux'] |
Member
There was a problem hiding this comment.
Suggested change
| - ['ext_gaap_GaapFlux_1_15x_1_5', 'gaap1p5Flux'] |
yalsayyad
force-pushed
the
tickets/DM-52922
branch
3 times, most recently
from
3b87fa8 to
c44018c
Compare
ctslater
approved these changes
Nov 7, 2025
schemas/Object.yaml
Outdated
| # kronRad50Err: Need to compute DM-16313 | ||
| # kronRad90: Need to compute DM-16313 | ||
| # kronRad90Err: Need to compute DM-16313 | ||
| # apFlux renamed to calibFlux because it is not guaranteed to be an apFlux |
Member
There was a problem hiding this comment.
Comment is outdated once calibFlux is gone.
- Leave reference centroid flag as coord_flag to match coord_ra/coord_dec names for refereence coords. Also TransformObjectCatalog currently doesn't let you reuse names being used for meas columns and centroid_flag was being used for <band>_centroid_flag.
yalsayyad
force-pushed
the
tickets/DM-52922
branch
from
c44018c to
e33794f
Compare
yalsayyad
force-pushed
the
tickets/DM-52922
branch
from
e33794f to
cdefdf8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.