DM-48966: refactoring of adaptive thresholding changes #1175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to allow for proper motion corrections.
This implementation is to allow the single frame processing calibration to handle a wide range of "scenes", e.g. crowded and/or high nebulosity ields in addition to the more "typical" regions, by implementing an adaptive and iterative thresholding based on the current detection masks and tuning the thresholds to adapt to the current scene. In general, higher detection thresholds are requird for non-standard fields to avoid large contiguous detection footprints which leave too few good isolated sources for calibration. To achieve the previous behaviour, the adaptive scheme can be turned off by setting the do_adaptive_threshold_detection config to False.
laurenam
force-pushed
the
tickets/DM-48966
branch
from
36aca54 to
2aa0488
Compare
The unit test was still fitting astrometry to the second-stage star catalog, even though the task itself had switched to using the PSF star catalog.
TallJimbo
force-pushed
the
u/jbosch/DM-48966
branch
from
5f4428a to
ff6d1b1
Compare
laurenam
force-pushed
the
tickets/DM-48966
branch
4 times, most recently
from
d3aa468 to
2341fdc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.