DM-43077: Convert all tasks to use CalibrateImageTask outputs #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parejkoj
force-pushed
the
tickets/DM-43077
branch
from
e7ef711
to
efe7d7d
Compare
Update test values to reflect the changed outputs. The image and background mean and std values went up by a factor of ~2, because the CalibrateImage output (`initial_pvi`) is photometrically calibrated, and the fitted calibration is ~2.18.
parejkoj
force-pushed
the
tickets/DM-43077
branch
from
9ead273
to
107ca63
Compare
taranu
reviewed
Oct 7, 2024
|
|
||
| # Confirm only calibrate task uses PropertySet. |
There was a problem hiding this comment.
Why was this the case anyway? If nobody remembers, oh well.
| ("summary.psfIxx", summary.psfIxx, 4.272794013403168, 5.1e-7), | ||
| ("summary.psfIyy", summary.psfIyy, 4.735316824053334, standard_atol), | ||
| ("summary.psfIxy", summary.psfIxy, -0.57899030354606, standard_atol), | ||
| ("im_mean", im_mean, 9.573747386158793, standard_atol), |
There was a problem hiding this comment.
These first four are huge changes... what happened?
There was a problem hiding this comment.
See my note in the commit message (seemed like the best place to put that): these images are calibrated to nJy, with a calibration factor of ~2.
| ("summary.dec", summary.dec, -0.23498074547048764, standard_atol), | ||
| ("summary.zenithDistance", summary.zenithDistance, 21.045745454754197, standard_atol), | ||
| ("summary.zeroPoint", summary.zeroPoint, 31.4, standard_atol), | ||
| ("summary.skyBg", summary.skyBg, 392.27323201298714, standard_atol), |
There was a problem hiding this comment.
Same here, why did skyBg more than double?
| def test_initial_stars(self): | ||
| initial_stars = self.butler.get("initial_stars_detector", | ||
| detector=self.detector, visit=self.visit) | ||
| self.assertEqual(len(initial_stars), 446) |
There was a problem hiding this comment.
Higher background and fewer stars is the right sign, I suppose, but again, quite a large change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.