DM-39464: Broadcasting query completion/cancellation events to Qserv workers #792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgates108
reviewed
Jun 15, 2023
jgates108
reviewed
Jun 15, 2023
iagaponenko
force-pushed
the
tickets/DM-39464
branch
from
2ce4cf1
to
f417c37
Compare
Eliminated unused definitions. Better names and return types for some methods.
The new implementation is based on the smart pointer to self be stored by the Qserv request classes. It would guarantee the life span of the request objects while request processing is still going on. Otherwse, there is a chance of running into crashes. The request cancellaton method has been added to replace SSI's Finished(true) to do a proper clean up of the stored pointer.
Added the corresponidng requests handler at workers. Added a new transient class representing the API for sending query management requests. Added a command-line tool to test requests.
…ation Added Czar configuration options to disable this feature if needed. The options will exist for some time before the new code will be proven to work w/o any side effects to the query processing.
fritzm
approved these changes
Jun 20, 2023
iagaponenko
force-pushed
the
tickets/DM-39464
branch
from
f417c37
to
a0b20e5
Compare
iagaponenko
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.